Skip to content

ENH: Update MINC to fdf1845#5873

Merged
blowekamp merged 3 commits intoInsightSoftwareConsortium:mainfrom
blowekamp:update_minc_fdf1845
Mar 6, 2026
Merged

ENH: Update MINC to fdf1845#5873
blowekamp merged 3 commits intoInsightSoftwareConsortium:mainfrom
blowekamp:update_minc_fdf1845

Conversation

@blowekamp
Copy link
Member

@blowekamp blowekamp commented Mar 6, 2026

Summary

Update the vendored MINC (libminc) third-party library from commit e5064e43 (2026-02-09) to commit fdf18452 (2026-02-21).

Upstream commit: BIC-MNI/libminc@fdf1845

Changes

  • config.h.cmake: Various configuration updates (80 lines changed)
  • CMakeLists.txt: Upstream switched to GNUInstallDirs defaults (${CMAKE_INSTALL_LIBDIR} instead of lib${LIB_SUFFIX} for CMAKE_INSTALL_RPATH). ITK's local patch preserving ${LIBMINC_EXTERNAL_LIB_PREFIX}minc2 for VOLUME_IO_LIBRARY was carried forward.

Conflict Resolution

There was a single merge conflict in Modules/ThirdParty/MINC/src/libminc/CMakeLists.txt. The upstream change used ${CMAKE_INSTALL_LIBDIR} (GNUInstallDirs) for CMAKE_INSTALL_RPATH, while ITK had a local patch for VOLUME_IO_LIBRARY. Both changes were preserved in the resolution.

Notes

  • No symbol mangling files present in this module — no mangling updates needed.
  • This commit was generated by the update-third-party skill.

blowekamp and others added 3 commits March 6, 2026 16:35
@github-actions github-actions bot added type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots type:Enhancement Improvement of existing methods or implementation area:ThirdParty Issues affecting the ThirdParty module labels Mar 6, 2026
@blowekamp
Copy link
Member Author

blowekamp commented Mar 6, 2026

This update addresses a build error with SimpleITK, by using cmake_minimum_required with a version range for policies.

CMake Warning (dev) at /work/SimpleITK-super/venv/lib/python3.12/site-packages/cmake/data/share/cmake-3.29/Modules/CTest.cmake:50 (option):
  Policy CMP0077 is not set: option() honors normal variables.  Run "cmake
  --help-policy CMP0077" for policy details.  Use the cmake_policy command to
  set the policy and suppress this warning.

  For compatibility with older versions of CMake, option is clearing the
  normal variable 'BUILD_TESTING'.
Call Stack (most recent call first):
  /work/SimpleITK-super/_deps/itk-src/Modules/ThirdParty/MINC/src/libminc/CMakeLists.txt:23 (include)
This warning is for project developers.  Use -Wno-dev to suppress it.

dzenanz
dzenanz approved these changes Mar 6, 2026
View reviewed changes
Copy link
Member

@dzenanz dzenanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on a glance.

@blowekamp blowekamp requested a review from hjmjohnson March 6, 2026 18:37
@blowekamp blowekamp merged commit cf6e3c9 into InsightSoftwareConsortium:main Mar 6, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thewtex thewtex thewtex approved these changes

@dzenanz dzenanz dzenanz approved these changes

@hjmjohnson hjmjohnson Awaiting requested review from hjmjohnson

Assignees

No one assigned

Labels

area:ThirdParty Issues affecting the ThirdParty module type:Enhancement Improvement of existing methods or implementation type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@blowekamp @thewtex @dzenanz @vfonov